GeoPolygonFilter fails on ambiguous polygons #9304
Labels
Comments
nknize
added
:Analytics/Geo
nknize
added a commit
to nknize/elasticsearch
that referenced
this issue
Jan 27, 2015
PR elastic#8672 addresses ambiguous polygons - those that either cross the dateline or span the map - by complying with the OGC standard right-hand rule. Since ```GeoPolygonFilter``` is self contained logic, the fix in elastic#8672 did not address the issue for the ```GeoPolygonFilter```. This was identified in issue elastic#5968 This fixes the ambiguous polygon issue in ```GeoPolygonFilter``` by moving the dateline crossing code from ```ShapeBuilder``` to ```GeoUtils``` and reusing the logic inside the ```pointInPolygon``` method. Unit tests are added to ensure support for coordinates specified in either standard lat/lon or great-circle coordinate systems. closes elastic#5968 closes elastic#9304
nknize
added a commit
that referenced
this issue
Jan 27, 2015
PR #8672 addresses ambiguous polygons - those that either cross the dateline or span the map - by complying with the OGC standard right-hand rule. Since ```GeoPolygonFilter``` is self contained logic, the fix in #8672 did not address the issue for the ```GeoPolygonFilter```. This was identified in issue #5968 This fixes the ambiguous polygon issue in ```GeoPolygonFilter``` by moving the dateline crossing code from ```ShapeBuilder``` to ```GeoUtils``` and reusing the logic inside the ```pointInPolygon``` method. Unit tests are added to ensure support for coordinates specified in either standard lat/lon or great-circle coordinate systems. closes #5968 closes #9304
nknize
added a commit
that referenced
this issue
Jan 27, 2015
PR #8672 addresses ambiguous polygons - those that either cross the dateline or span the map - by complying with the OGC standard right-hand rule. Since ```GeoPolygonFilter``` is self contained logic, the fix in #8672 did not address the issue for the ```GeoPolygonFilter```. This was identified in issue #5968 This fixes the ambiguous polygon issue in ```GeoPolygonFilter``` by moving the dateline crossing code from ```ShapeBuilder``` to ```GeoUtils``` and reusing the logic inside the ```pointInPolygon``` method. Unit tests are added to ensure support for coordinates specified in either standard lat/lon or great-circle coordinate systems. closes #5968 closes #9304
|
Reopening due to #9462 |
clintongormley
changed the title
|
Bumping the version up to 1.7.1 for the today's release. |
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
PR elastic#8672 addresses ambiguous polygons - those that either cross the dateline or span the map - by complying with the OGC standard right-hand rule. Since ```GeoPolygonFilter``` is self contained logic, the fix in elastic#8672 did not address the issue for the ```GeoPolygonFilter```. This was identified in issue elastic#5968 This fixes the ambiguous polygon issue in ```GeoPolygonFilter``` by moving the dateline crossing code from ```ShapeBuilder``` to ```GeoUtils``` and reusing the logic inside the ```pointInPolygon``` method. Unit tests are added to ensure support for coordinates specified in either standard lat/lon or great-circle coordinate systems. closes elastic#5968 closes elastic#9304
|
removing the 1.x version label here, it just keeps getting bumped since ages. Please remember this when closing, that it might need to be backported |
|
It looks like this was addressed by 1a60e1c#diff-48767b395fcd07ab92b9c05815741b74R221 Can we close this now? |
|
+1 to close. I knew this one would eventually resolve itself but I forgot the issue was still open. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Polygon ambiguity was addressed in
ShapeBuildervia #8762.GeoPolygonFilter, however, doesn't useShapeBuilderand instead relies on legacypointInPolygoncode that fails on ambiguous polygons. One use-case example is presented in #5968 The suggested fix is to translate all candidate points andGeoPolygonFilterpoints to great-circle coordinates. This, however, will cause a failure with anyGeoPolygonFilterthat crosses the prime meridian.The correct approach is to update the
GeoPolygonFilterto leverage code written in #8762 by refactoring the ambiguous polygon logic to helper methods. This will also remove any legacy code (and rename any parameters) that might cause confusion when using the Java API.The text was updated successfully, but these errors were encountered: