The parent filter of the nested aggregator isn't resolved correctly all the time #9335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
v2.0.0-beta1
v1.5.0
v1.4.2
v1.4.3
v1.3.8
>bug
review
and removed
v1.4.2
labels
martijnvg
changed the title
nested aggregator's parent filter is n't resolved properly i...
|
Can you elaborate a bit why it does not work correctly today? |
|
When aggregations aren't created before collection started (so not the top Moving the resolving of the On 20 January 2015 at 00:22, Adrien Grand notifications@github.com wrote:
Met vriendelijke groet, Martijn van Groningen |
|
LGTM |
|
I see @martijnvg , thanks for the explanation. I think we should make the framework more resilient to this kind of corner cases in the long term, but +1 to your fix as this would be quite a hard task. |
…y in the case the nested agg gets created on the fly for buckets that are constructed during query execution. The fix is the move the parent filter resolving from the nextReader(...) method to the collect(...) method, because only then any parent nested filter's parent filter is then properly instantiated. Closes elastic#9280 Closes elastic#9335
martijnvg
force-pushed
the
bugs/nested_parent_filter_not_resolved_properly
branch
from
00bdced
to
061337f
Compare
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jan 26, 2015
…y in the case the nested agg gets created on the fly for buckets that are constructed during query execution. The fix is the move the parent filter resolving from the nextReader(...) method to the collect(...) method, because only then any parent nested filter's parent filter is then properly instantiated. Closes elastic#9280 Closes elastic#9335
martijnvg
added a commit
that referenced
this pull request
Jan 26, 2015
…y in the case the nested agg gets created on the fly for buckets that are constructed during query execution. The fix is the move the parent filter resolving from the nextReader(...) method to the collect(...) method, because only then any parent nested filter's parent filter is then properly instantiated. Closes #9280 Closes #9335
martijnvg
added a commit
that referenced
this pull request
Jan 26, 2015
…y in the case the nested agg gets created on the fly for buckets that are constructed during query execution. The fix is the move the parent filter resolving from the nextReader(...) method to the collect(...) method, because only then any parent nested filter's parent filter is then properly instantiated. Closes #9280 Closes #9335
clintongormley
changed the title
clintongormley
added
:Nested Docs
and removed
:Analytics/Aggregations
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…y in the case the nested agg gets created on the fly for buckets that are constructed during query execution. The fix is the move the parent filter resolving from the nextReader(...) method to the collect(...) method, because only then any parent nested filter's parent filter is then properly instantiated. Closes elastic#9280 Closes elastic#9335
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…y in the case the nested agg gets created on the fly for buckets that are constructed during query execution. The fix is the move the parent filter resolving from the nextReader(...) method to the collect(...) method, because only then any parent nested filter's parent filter is then properly instantiated. Closes elastic#9280 Closes elastic#9335
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nestedaggregator's parent filter isn't resolved properly in the case the nested agg gets created on the fly for buckets that are constructed during query execution.The fix is the move the parent filter resolving from the nextReader(...) method to the collect(...) method, because only then any parent nested filter's parent filter is then properly instantiated.
Closes #9280