Remove _analyzer field
#9381
Merged
Remove _analyzer field
#9381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
changed the title
|
@imotov I updated this to only include _analyzer removal. |
| if (!forcedQuoteAnalyzer) { | ||
| setAnalyzer(fieldMappers.searchQuoteAnalyzer()); | ||
| } | ||
| setAnalyzer(fieldMappers.searchQuoteAnalyzer()); | ||
| } else { |
There was a problem hiding this comment.
Wouldn't these changes belong to query analyzer PR?
There was a problem hiding this comment.
Oops, missed this part when reverting. Will fix.
|
I left a couple of minor comments, but in general it looks good to me. I also think we should delete analyzer-field.asciidoc from master as part of this PR. |
|
Thanks @imotov. I pushed fixes for your comments. |
|
LGTM |
clintongormley
added
the
:Search/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the per query analyzer still exists for MultiTermQuery. That
needs to be looked at separately on how to remove...
closes #9279