New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove type level default analyzers #9430
Conversation
The change looks good. Something that I'm missing is what the expected behaviour is when a user upgrades from 1.x to 2.x. I see the parsing logic has been removed from DocumentMapperParser so I believe that starting a 1.x index with per-type default analyzers would fail on 2.x? |
@jpountz good catch. There are two conflicting needs here:
I think we should throw an exception by default, so that the user knows that there is a problem (rather than just silently changing behaviour), but we need to provide some way for the user to say "go ahead and use this index anyway". Possibilities:
any preferences or better ideas? |
That's what I thought at first, and had extra logic in the parser to log and skip when it saw these old settings. However, I found that this worked even without my extra logic (with the restore bwc tests). The validation function, which checks if there are any extra settings, only throws exception on index creation on or after 2.0. If the index was created before 2.0, it only logs a warning. @clintongormley This PR is for removing per type analyzer defaults... |
I had missed it was only enabled for new indices! Thanks for the explanation. |
LGTM |
These settings were removed in #9430.
@clintongormley I removed the documentation for it in master and added a deprecation warning in 1.x. |
Notes for reviewers:
closes #8874