Test: use local gateway by default #9476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LocalGateway contains important functionality for the correct behavior of elasticsearch. As an optimization, it was replaced with the NoneGateway as a default for testing. However, this has proven to cause nasty-to-trace build failures which are not worth the extra speed up. The NoneGateway was already removed from master. This commit doesn't remove it due to bwc but changes the default to the local gateway.
|
LGTM! |
bleskes
added a commit
that referenced
this pull request
Jan 29, 2015
The LocalGateway contains important functionality for the correct behavior of elasticsearch. As an optimization, it was replaced with the NoneGateway as a default for testing. However, this has proven to cause nasty-to-trace build failures which are not worth the extra speed up. The NoneGateway was already removed from master. This commit doesn't remove it due to bwc but changes the default to the local gateway. Closes #9476
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Jan 29, 2015
The LocalGateway contains important functionality for the correct behavior of elasticsearch. As an optimization, it was replaced with the NoneGateway as a default for testing. However, this has proven to cause nasty-to-trace build failures which are not worth the extra speed up. The NoneGateway was already removed from master. This commit doesn't remove it due to bwc but changes the default to the local gateway. Closes elastic#9476
|
pushed to 1.x and 1.4 |
|
this should not go to 1.4, sorry this is a big change and can lead to a lot of wasted time. On a release branch you should't do stuff like this. |
|
I back ported this out of 1.x and 1.4, as it brings too much test infra instability. I will work on syncing the test infra with master (where NoneGateway was removed) and re-submit. |
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
The LocalGateway contains important functionality for the correct behavior of elasticsearch. As an optimization, it was replaced with the NoneGateway as a default for testing. However, this has proven to cause nasty-to-trace build failures which are not worth the extra speed up. The NoneGateway was already removed from master. This commit doesn't remove it due to bwc but changes the default to the local gateway. Closes elastic#9476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LocalGateway contains important functionality for the correct behavior of elasticsearch. As an optimization, it was replaced with the NoneGateway as a default for testing. However, this has proven to cause nasty-to-trace build failures which are not worth the extra speed up. The NoneGateway was already removed from master. This commit doesn't remove it due to bwc but changes the default to the local gateway.