Remove dirty flag and force boolean for refresh #9484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -694,7 +684,7 @@ public boolean refreshNeeded() { | |||
| try { | |||
| // we are either dirty due to a document added or due to a | |||
There was a problem hiding this comment.
This comment is a bit stale, e.g. says "dirty" (which is gone) and e.g. deletes can also mean we are not current ... I think just remove the comment?
|
LGTM, what a nice cleanup: 2 booleans and 1 mutex removed! |
|
@mikemccand I pushed updates |
|
LGTM, thanks @s1monw! |
Today we have a dirty flag indicating that a refresh must be executed. We also allow users to bypass this by setting a force=true boolean on the refresh request / command. All these flags are unneeded since the SearcherManager has all the information to do the right thing if it's dirty or not.
s1monw
force-pushed
the
remove_force_refresh
branch
from
4431e90
to
03f1fcc
Compare
| indexShard.refresh("api", request.force()); | ||
| logger.trace("{} refresh request executed, force: [{}]", indexShard.shardId(), request.force()); | ||
| indexShard.refresh("api"); | ||
| logger.trace("{} refresh request executed, force: [{}]", indexShard.shardId()); |
There was a problem hiding this comment.
should remove the "force:[{}]" in trace logger. @s1monw
|
Thanks @boliza I'll push a fix. |
|
@mikemccand @dakrone I think I should backport this to 1.x too. WDYT |
|
++ @s1monw |
|
yes, +1 on backport to 1.x |
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have a dirty flag indicating that a refresh must
be executed. We also allow users to bypass this by setting
a force=true boolean on the refresh request / command. All
these flags are unneeded since the SearcherManager has all
the information to do the right thing if it's dirty or not.