Reset TieredMP settings only if the value actually changed #9497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I wonder if this is the cause of #8890 |
yes indeed.... I will fix the other providers too and add tests |
| TieredMergePolicyProvider mp = new TieredMergePolicyProvider(createStore(EMPTY_SETTINGS), service); | ||
| assertThat(mp.getMergePolicy().getNoCFSRatio(), equalTo(0.1)); | ||
|
|
||
| assertEquals(mp.getMergePolicy().getForceMergeDeletesPctAllowed(), TieredMergePolicyProvider.DEFAULT_EXPUNGE_DELETES_ALLOWED, 0.0d); |
There was a problem hiding this comment.
I think we need to add a check that other settings do not spring back to their defaults, which I believe was the original issue (update one setting and have all the rest go back to default).
There was a problem hiding this comment.
see the bottom of the test there is a update call with empty settings
There was a problem hiding this comment.
missed that. All good then. Sorry for the noise.
|
Fix LGTM. Added one comment about the test. |
|
Thanks for picking it up! 👍 |
|
@mikemccand @bleskes I fixed the other MPs as well can you take a look? |
Due to some unreleased refactorings we lost the persitence of a perviously set values in MergePolicyProvider. This commit adds this back and adds a simple unittest. Closes elastic#8890
clintongormley
changed the title
clintongormley
added
>bug
:Core/Infra/Settings
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some unreleased refactorings we lost the persitence of
a perviously set values in TieredMPProvider. This commit adds this
back and adds a simple unittest.
Closes #8890