CliTool: Add command to warn on permission/owner change #9508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
When using the CLI tool infrastructure, a command can potentially write a new file. In case it overwrites an existing one, you may want to ensure that the permissions, the owner and the group are kept the same and do not accidentally change when overwriting those files. This PR introduces a command that allows you to execute this check per path. It also adds a new testing dependency, namely jimfs, which allows you to create in-memory filesystems with certain properties (like supporting or not posix permissions on this filesystem), so that you can test those features, without executing tests on a certain operating system.
spinscale
force-pushed
the
1501-feature-cli-command-that-checks-permissions
branch
from
3910bc6
to
9cd14a5
Compare
dadoonet
added a commit
to elastic/elasticsearch-parent
that referenced
this pull request
May 22, 2015
Sounds like this dependency is missing in parent elastic/elasticsearch#9508 Closes #44.
clintongormley
added
the
:Delivery/Packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the CLI tool infrastructure, a command can potentially write
a new file. In case it overwrites an existing one, you may want to ensure
that the permissions, the owner and the group are kept the same and do not
accidentally change when overwriting those files.
This PR introduces a command that allows you to execute this check per path and writes out an warn message in case of changes.
It also adds a new testing dependency, namely jimfs, which allows you to create
in-memory filesystems with certain properties (like supporting or not posix permissions
on this filesystem), so that you can test those features, without executing
tests on a certain operating system.