Add beforeIndexAddedToCluster callback
#9514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
dakrone
force-pushed
the
lifecycle-cleanup
branch
2 times, most recently
from
a1b3d37
to
9fe8406
Compare
This callback is executed only once, on the master node during an index's creation. An exception thrown during this listener will cancel the index creation. This also adds checks in `IndicesClusterStateService` for the indexService being null as well as if the `indicesService.createIndex` throws an exception on data nodes after an index has already been created.
| @@ -220,6 +220,10 @@ private void applyCleanedIndices(final ClusterChangedEvent event) { | |||
| // handle closed indices, since they are not allocated on a node once they are closed | |||
| // so applyDeletedIndices might not take them into account | |||
| for (IndexService indexService : indicesService) { | |||
| if (indexService == null) { | |||
There was a problem hiding this comment.
checking here for null is not benefetial I think, it can't be null...., same applies to other null checks while iterating
|
@dakrone I see it was merged, but at least the last comment I gave is critical |
|
@kimchy I will fix that, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This callback is executed only once, on the master node during an
index's creation. An exception thrown during this listener will cancel
the index creation.
This also adds checks in
IndicesClusterStateServicefor theindexService being null as well as if the
indicesService.createIndexthrows an exception on data nodes after an index has already been
created.