[TEST] support stashed values within property names in our REST tests #9533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
force-pushed
the
test/stash_in_path
branch
from
ed93b88
to
92a83e5
Compare
javanna
added
>test
| @@ -246,6 +243,7 @@ public static void runUpgrade(HttpRequestBuilder httpClient, String index, Strin | |||
| assertEquals(200, rsp.getStatusCode()); | |||
| } | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
There was a problem hiding this comment.
While the changes to this file seem fine, I don't understand what they have to do with this PR?
There was a problem hiding this comment.
nothing....just that I went over this class because it used JsonPath#evaluate which I was changing and then I went wild on fixing compiler warnings.... can revert :)
There was a problem hiding this comment.
it's perfectly fine to clean these things up as we go... I don't see a need to have separate PRs for these small cleanups
There was a problem hiding this comment.
I don't have a problem with the change. I was trying to understand why it was here.
|
LGTM |
…object We had a REST test that relied on matching a json response against a regex. It worked but the match wasn't done against the actual json object, but its java map representation converted into a string by calling `toString`. Since all other clients test runners don't work in this case, as they try to match a json object against a regex, we should do the same and prevent it from working.
javanna
force-pushed
the
test/stash_in_path
branch
from
83b8e92
to
0e67dda
Compare
javanna
added a commit
that referenced
this pull request
Feb 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support stashed values within property names, feature that was added to the REST spec in e7ac5f2 .