New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Putting index settings in twice causes ES to crash from assertion error #95347
Comments
Pinging @elastic/es-core-infra (Team:Core/Infra) |
The reason this assertion is tripping is because So the best thing to do here might be to just remove these assertions - its ok for the settings version to increment without anything changing. But this is more distributed's area, so pinging them for a second opinion |
Pinging @elastic/es-distributed (Team:Distributed) |
It has been suggested that we reject attempts to set the number of replicas while That said, this is definitely a |
@DaveCTurner This doesn't seem to have to do with the specific settings set in this issue, but in general with how the settings differences are calculated, as @thecoop noted. Since the assertions in question live in IndexService, it seems to me to be more of a question for the Distributed team, though this is probably a gray area. Are you comfortable removing the assertions? |
@rjernst @DaveCTurner Would it help if I add another reproduction case here? Namely, trying to modify a data stream to replace an existing backing index with a downsample index will run into this problem as well (https://github.com/elastic/elasticsearch/pull/91141/files#diff-3525330b076f1366498e871381f6f4a3fe7e0127b55e863227a3b98cf29d7e6cR128 ) The workaround is not great https://github.com/elastic/elasticsearch/pull/91141/files#diff-3525330b076f1366498e871381f6f4a3fe7e0127b55e863227a3b98cf29d7e6cR110 |
Is there any update on this? It still reproduces on |
Elasticsearch Version
8.8.0-SNAPSHOT
Installed Plugins
No response
Java Version
bundled
OS Version
n/a
Problem Description
It's possible to cause an assert failure by putting the same index settings into an index twice.
Steps to Reproduce
When running on the
main
branch, with./gradlew run
(so that asserts are enabled), it is possible to easily crash Elasticsearch with the following:Putting the same settings in twice causes this assertion to trip:
Logs (if relevant)
No response
The text was updated successfully, but these errors were encountered: