Take filters from aliases into account #9590
Conversation
|
|
||
| final Filter filter; | ||
| if (context.aliasFilter() != null) { | ||
| filter = new AndFilter(Arrays.asList(context.aliasFilter(), percolatorTypeFilter)); |
There was a problem hiding this comment.
order matters here right? wondering if type shouldn't be first, given that we don't know how expensive the alias filter will be since it's user provided. Thoughts?
There was a problem hiding this comment.
yes in the and filter that does matter. My reasoning was that the alias filter is more specific and will exclude more docs and that is why I put it first... Maybe I should use the bool filter instead, where such decisions are made automatically. (in master we can use bool query :) which is even better)
|
left a few cosmetic comments, LGTM otherwise |
martijnvg
force-pushed
the
percolator/filtered_alias
branch
from
1631d8a
to
b6bd0e0
Compare
|
@javanna I applied your feedback. Did my answers make sense? |
|
answers made sense, thanks @martijnvg . Left a couple of comments around code comments in tests. LGTM though! |
…ng queries to run on a document. The filter from an indexed alias is as if you would filter on the metadata of a percolator query, but then the filter is defined in the index alias instead of the percolate request. Closes elastic#6241
martijnvg
force-pushed
the
percolator/filtered_alias
branch
from
b6bd0e0
to
f72a0b8
Compare
clintongormley
added
the
:Search/Percolator
clintongormley
changed the title
Take filters from index aliases into account when selecting queries to run on a document.
The filter from an indexed alias is as if you would filter on the metadata of a percolator query, but then the filter is defined in the index alias instead of the percolate request.
PR for #6241