FileSystemUtils: Only create backup copies if files differ #9592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
| @@ -205,14 +208,42 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IO | |||
| // We just move the new file to new dir | |||
| Files.move(file, path); | |||
There was a problem hiding this comment.
To be coherent with the preVisitDirectory() method I think we should use the FileSystemUtils.move() method instead of Files.move() that doesn't support moving non-empty directories between different filesystems.
|
LGTM, left one comment. |
spinscale
force-pushed
the
1502-filesystemutils-check-md5sum
branch
from
fe8f1f6
to
879a692
Compare
|
@tlrx updated the PR |
|
@spinscale I just tested it, LGTM |
spinscale
force-pushed
the
1502-filesystemutils-check-md5sum
branch
2 times, most recently
from
f8ecc56
to
332e1ed
Compare
The FileSystemUtils class has a helper method to create files with a .new suffix, in case the file, which should be created already exists. If you install plugins and those have configuration files, even without changes, you will end up with tons of .new files. This commit checks the file size and sha-256 sum, and only if those differ, a .new file is actually being created.
spinscale
force-pushed
the
1502-filesystemutils-check-md5sum
branch
from
332e1ed
to
30a9d97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FileSystemUtils class has a helper method to create files with
a .new suffix, in case the file, which should be created already
exists. If you install plugins and those have configuration files,
even without changes, you will end up with tons of .new files.
This commit checks the file size and sha-256 sum, and only if those
differ, a .new file is actually being created.