Update joda-time to v2.7 #9610
Closed
Update joda-time to v2.7 #9610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // validate not over maximum | ||
| if (iChronology.year().isSupported()) { | ||
| iChronology.year().set(iMillis, iChronology.year().get(iMillis)); | ||
| } |
There was a problem hiding this comment.
I assume this diff is the difference between this class in 2.3 and 2.7, is it correct?
|
@v1ctor I left one question on the diff, if you could confirm this would be great |
|
@jpountz I have answered you, thanks! |
|
@spinscale could you take a look at this too please? |
|
I'll leave @spinscale have a look too but it looks good to me. |
|
will do, comparing changelogs and running tests... for the curious, changelogs are at |
|
Hi, everyone! |
clintongormley
added
>upgrade
and removed
:Core/Infra/Core
clintongormley
added
:Search/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I have updated joda-time to v2.7 under issue #9338.