Promptly cleanup updateTask timeout handler #9621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
:Core/Infra/Core
| if (command instanceof TieBreakingPrioritizedRunnable) { | ||
| ((TieBreakingPrioritizedRunnable)command).scheduleTimeout(timer, timeoutCallback, timeout); | ||
| } else { | ||
| // TODO: should we add support or remove PrioritizedFutureTask completely since it's not used? |
There was a problem hiding this comment.
+1 lets get rid of it! If we don't use it there is no need for the complexity!
|
LGTM |
|
btw this needs to go into 1.3.8 too |
Improve cleanup of updateTask timeout handlers. The timeout handlers should be removed as soon as a corresponding update task is processed. Otherwise, timeout handlers might keep old updateTasks and all objects that they are pointing to in memory for the duration of timeout (15 minutes by default). Fixes elastic#9621
imotov
force-pushed
the
fix-timeout-handling
branch
from
b544c0e
to
6544890
Compare
imotov
added a commit
that referenced
this pull request
Feb 10, 2015
Improve cleanup of updateTask timeout handlers. The timeout handlers should be removed as soon as a corresponding update task is processed. Otherwise, timeout handlers might keep old updateTasks and all objects that they are pointing to in memory for the duration of timeout (15 minutes by default). Fixes #9621
imotov
added a commit
that referenced
this pull request
Feb 10, 2015
Improve cleanup of updateTask timeout handlers. The timeout handlers should be removed as soon as a corresponding update task is processed. Otherwise, timeout handlers might keep old updateTasks and all objects that they are pointing to in memory for the duration of timeout (15 minutes by default). Fixes #9621
imotov
added a commit
that referenced
this pull request
Feb 10, 2015
Improve cleanup of updateTask timeout handlers. The timeout handlers should be removed as soon as a corresponding update task is processed. Otherwise, timeout handlers might keep old updateTasks and all objects that they are pointing to in memory for the duration of timeout (15 minutes by default). Fixes #9621
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Improve cleanup of updateTask timeout handlers. The timeout handlers should be removed as soon as a corresponding update task is processed. Otherwise, timeout handlers might keep old updateTasks and all objects that they are pointing to in memory for the duration of timeout (15 minutes by default). Fixes elastic#9621
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
This caused by elastic#9671 and elastic#9621 working together and cause an NPE
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Improve cleanup of updateTask timeout handlers. The timeout handlers should be removed as soon as a corresponding update task is processed. Otherwise, timeout handlers might keep old updateTasks and all objects that they are pointing to in memory for the duration of timeout (15 minutes by default). Fixes elastic#9621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve cleanup of updateTask timeout handlers. The timeout handlers should be removed as soon as a corresponding update task is processed. Otherwise, timeout handlers might keep old updateTasks and all objects that they are pointing to in memory for the duration of timeout (15 minutes by default).
Implementing this for PrioritizedFutureTask is tricky. And since it's not used (nor tested), I am not sure if we should do it for the sake of completeness or it might be cleaner to just remove PrioritizedFutureTask altogether. Thoughts?