Introduce TimedPrioritizedRunnable base class to all commands that go into InternalClusterService.updateTasksExecutor #9671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds that go into InternalClusterService.updateTasksExecutor At the moment we sometime submit generic runnables, which make life slightly harder when generated pending task list which have to account for them. This commit adds an abstract TimedPrioritizedRunnable class which should always be used. This class also automatically measures time in queue, which is needed for the pending task reporting. Relates to elastic#8077 Closes elastic#9354
|
yeah that looks good to me as a general fix. I think we should also assert the timeInQueue is never negative in the pending task? |
| @@ -99,7 +101,7 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| out.writeLong(timeInQueue); | |||
| } else { | |||
| out.writeVLong(Math.max(0, timeInQueue)); | |||
There was a problem hiding this comment.
this is no longer needed. I'll fix this.
|
heh yeah! LGTM |
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Feb 12, 2015
…ds that go into InternalClusterService.updateTasksExecutor At the moment we sometime submit generic runnables, which make life slightly harder when generated pending task list which have to account for them. This commit adds an abstract TimedPrioritizedRunnable class which should always be used. This class also automatically measures time in queue, which is needed for the pending task reporting. Relates to elastic#8077 Closes elastic#9354 Closes elastic#9671
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Feb 12, 2015
…ds that go into InternalClusterService.updateTasksExecutor At the moment we sometime submit generic runnables, which make life slightly harder when generated pending task list which have to account for them. This commit adds an abstract TimedPrioritizedRunnable class which should always be used. This class also automatically measures time in queue, which is needed for the pending task reporting. Relates to elastic#8077 Closes elastic#9354 Closes elastic#9671
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ds that go into InternalClusterService.updateTasksExecutor At the moment we sometime submit generic runnables, which make life slightly harder when generated pending task list which have to account for them. This commit adds an abstract TimedPrioritizedRunnable class which should always be used. This class also automatically measures time in queue, which is needed for the pending task reporting. Relates to elastic#8077 Closes elastic#9354 Closes elastic#9671
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
This caused by elastic#9671 and elastic#9621 working together and cause an NPE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we sometime submit generic runnables, which make life slightly harder when generated pending task list which have to account for them. This commit adds an abstract TimedPrioritizedRunnable class which should always be used. This class also automatically measures time in queue, which is needed for the pending task reporting.
Relates to #8077
Closes #9354