Testing: Ensure RepeatOnException rule is available in test-jar #9675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } catch (Throwable t) { | ||
| if (t.getClass().equals(expectedException)) { | ||
| caughtThrowable = t; | ||
| logger.info("Bind exception occurred, rerunning the test after [{}] failures", t, i+1); |
There was a problem hiding this comment.
is this still a bind exception all the time? If not we should update the error message
|
LGTM besides the small comment I left |
This moves the rule, so it is made available in the test.jar. In addition, you can now specify the exception, which triggers a rerun of the test in order to make it reusable for others. Also ensured that the NettyTransportTest frees all resources inside of its testing method instead of pre/post running methods, as those are still called only once, even though a failed test might be repeated.
spinscale
force-pushed
the
1502-testing-ensure-threadpool-shutdown-on-failure
branch
from
a35f873
to
ce24e10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the rule, so it is made available in the test.jar. In
addition, you can now specify the exception, which triggers a rerun
of the test in order to make it more usable for others.
Also ensured that the NettyTransportTest frees all resources inside
of its testing method instead of pre/post running methods, as those
are still called only once.