Move as much as possible into abstract Engine #9678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -181,6 +198,35 @@ public Condition newCondition() { | |||
|
|
|||
| public abstract void delete(DeleteByQuery delete) throws EngineException; | |||
|
|
|||
| protected GetResult getFromSearcher(Get get) throws EngineException { | |||
|
left minor comments LGTM feel free to push once fixed |
dakrone
force-pushed
the
abstract-engine
branch
from
8ab1bb8
to
9aed732
Compare
This paves the way for more shared code between the `InternalEngine` and `ShadowEngine` by way of the abstract `Engine` class. No actual functionality has been changed.
|
Merged this to 1.x and master |
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This paves the way for more shared code between the
InternalEngineandShadowEngineby way of the abstractEngineclass. No actualfunctionality has been changed.