Use Directory#fileLength() less during calculating checksums #9689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmuir can you take a look |
| final long length; | ||
| try (final IndexInput in = directory.openInput(segmentsFile, IOContext.READONCE)) { | ||
| length = in.length(); | ||
| hashFile(fileHash, new InputStreamIndexInput(in, length), length); |
There was a problem hiding this comment.
I think its awkward we wrap these files in InputStreamIndexInput here, and have the method take InputStream, when it could just take DataInput?
The one lone other usage of it, in a separate file (BlobStoreIndexShardRepository), could just wrap its InputStream with a o.a.l.util.InputStreamDataInput. and then the hashFile() would just be a simple readBytes() call into the byte array.
I know this isn't new in the patch, but this path adds more indexinput-wrapping since its not calling hashFile(String) anymore.
There was a problem hiding this comment.
I will refactor this in a different PR
|
looks good. i added a cosmetic comment, maybe for the future. |
clintongormley
added
:Distributed/Store
clintongormley
changed the title
clintongormley
added
:Distributed/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.