Don't use the fixed bitset filter cache for child nested level filters, but the regular filter cache instead #9740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
force-pushed
the
nested/sorting/non_random_access_child_bitsets
branch
from
0506260
to
1ff3439
Compare
| return new NumericDocValues() { | ||
|
|
||
| int lastSeenRootDoc = -1; | ||
| long lastEmittedValue; |
There was a problem hiding this comment.
Should we rather initialize lastSeenRootDoc=0 and lastEmittedValue=missingValue to avoid the if (rootDoc == 0) check below?
There was a problem hiding this comment.
yes, that makes sense! I'll change that.
|
LGTM |
…s, but the regular filter cache instead. Random access based bitsets are not required for the child level nested level filters. Closes elastic#8810
martijnvg
force-pushed
the
nested/sorting/non_random_access_child_bitsets
branch
from
1ff3439
to
1644644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random access based bitsets are not required for the child level nested level filters.
Closes #8810