Upgrade to Lucene r1660560 #9746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parts that fail because of bad assumptions
|
FYI, I re-enabled the non debuggable test (indeed it was very difficult to debug) and commented out the portions that cause problems, along with adding comments as to why they fail. |
| TopFieldDocs[] shardDocs = new TopFieldDocs[aggregations.size()]; | ||
| for (int i = 0; i < shardDocs.length; i++) { | ||
| InternalTopHits topHitsAgg = (InternalTopHits) aggregations.get(i); | ||
| // TODO: topdocs.merge is this really safe? our topDocs is a TopFieldDocs... |
There was a problem hiding this comment.
@jpountz could you have a look at this one? It made me nervous (not sure the stronger typing is safe).
|
whew, awesome ryan! Thanks for all your help here (mike too). Another thing to mention, the "TODO: topdocs.merge" (there are two of these), we need to look into them. Mike had them as nocommits and maybe they should be... |
|
I'm looking into those TopDocs.merge issues. |
|
@mikemccand I pushed a new commit that hopefully makes usage of TopDocs.merge better. Let me know what you think? |
|
Thanks @jpountz that looks much cleaner. |
clintongormley
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isnt an easy one. I deferred a lot of work until later.
There are a lot of followups we can do. I don't plan on working on these, or opening issues for these, they are just ideas.
One test is especially bad. It is not debuggable and I disabled it. It tries to use the postings lists (in wierd ways) from groovy apis or something like that. Besides the point of testing, this alone seems like a bad idea. We should remove tests like this from the codebase, they just waste time. This test really ruined my day and discouraged me from working any further. Please consider the person debugging when writing tests.