PercentageScore heuristic for significant_terms
#9747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brwe This seemed a simple but potentially common heuristic so I added a native implementation rather than relying on a scripted solution. I added a cautionary note in the reference docs about use on fields with low-frequency terms after some trials on real data. |
| @@ -42,10 +42,10 @@ protected void checkFrequencyValidity(long subsetFreq, long subsetSize, long sup | |||
| throw new ElasticsearchIllegalArgumentException("Frequencies of subset and superset must be positive in " + scoreFunctionName + ".getScore()"); | |||
| } | |||
| if (subsetFreq > subsetSize) { | |||
| throw new ElasticsearchIllegalArgumentException("subsetFreq > subsetSize, in JLHScore.score(..)"); | |||
| throw new ElasticsearchIllegalArgumentException("subsetFreq > subsetSize, in " + scoreFunctionName + ".score(..)"); | |||
There was a problem hiding this comment.
Do we need the .score(..) here? For the user all they need to know is the score function that failed. The method is probably not relevant to the user in the message and will be in the stack trace for a dev investigating anyway
…t_terms aggregation provides simple “per-capita” type measures. Closes #9720
|
LGTM |
|
Merged in 4d26492 |
clintongormley
added
>feature
v2.0.0-beta1
v1.5.0
:Analytics/Aggregations
clintongormley
changed the title
PercentageScore heuristic for significant_terms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides simple “per-capita” type scoring measure for use on higher-frequency terms
Closes #9720