Only iterate the files that we recovered from the commit #9761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM do we want a test that injects evil files? |
that one is going be available at the lucene release next to you soon |
Today we use Directory#listAll() to find all the files we recovered. Yet, this is not accurate since there might be leftovers etc. It's better to only iterate over the known files from the segments info that we recovered.
s1monw
force-pushed
the
take_files_from_commit
branch
from
a8a5aad
to
50a56b6
Compare
| */ | ||
| public static Iterable<String> files(SegmentInfos infos) throws IOException { | ||
| final List<Collection<String>> list = new ArrayList<>(); | ||
| for (SegmentCommitInfo info : infos) { |
There was a problem hiding this comment.
Should this include the segments file? (e.g. call infos.files() instead) The old listAll() would have included it too.
There was a problem hiding this comment.
pushed a fix for this here e8f276b
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Feb 20, 2015
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Feb 20, 2015
clintongormley
added
:Distributed/Recovery
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we use Directory#listAll() to find all the files we recovered. Yet,
this is not accurate since there might be leftovers etc. It's better to
only iterate over the known files from the segments info that we recovered.