Hot threads should include timestamp and params #9773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, this is a nice addition |
mikemccand
added a commit
that referenced
this pull request
Feb 19, 2015
Include the timestamp and params (interval, busiestThreads, ignoreIdleThreads), when hot threads were collected. Closes #9773
clintongormley
added
>enhancement
:Data Management/Stats
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at a hot threads output, it's useful to know the exact time when the hot threads were taken, e.g. to correlate back to Marvel charts or other monitors. If multiple hot threads were pulled at different times it's useful to know which one was when.
I think it's also useful to know the params that were passed (interval, busiestThreads count, whether idle threads were ignored).
This change just adds a line at the top of each node's hot threads, like this:
Hot threads at 2015-02-19T10:33:52.333Z, interval=500ms, busiestThreads=2147483647, ignoreIdleThreads=false: