New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggs: breadth_first does not work on several levels #9823
Labels
Comments
jpountz
changed the title
Aggs: breadth_first does not work on several leves
Aggs: breadth_first does not work on several levels
Apr 3, 2015
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this issue
Apr 3, 2015
The refactoring in elastic#9544 introduced a regression that broke multi-level aggregations using breadth-first. This was due to sub-aggregators creating deferred collectors before their parent aggregator and then the parent aggregator trying to collect sub aggregators directly instead of going through the deferred wrapper. This commit fixes the issue but we should try to simplify all the pre/post collection logic that we have. Also `breadth_first` is now automatically ignored if the sub aggregators need scores (just like we ignore `execution_mode` when the value does not make sense like using ordinals on a script). Close elastic#9823
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this issue
Apr 9, 2015
The refactoring in elastic#9544 introduced a regression that broke multi-level aggregations using breadth-first. This was due to sub-aggregators creating deferred collectors before their parent aggregator and then the parent aggregator trying to collect sub aggregators directly instead of going through the deferred wrapper. This commit fixes the issue but we should try to simplify all the pre/post collection logic that we have. Also `breadth_first` is now automatically ignored if the sub aggregators need scores (just like we ignore `execution_mode` when the value does not make sense like using ordinals on a script). Close elastic#9823
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this issue
Apr 9, 2015
The refactoring in elastic#9544 introduced a regression that broke multi-level aggregations using breadth-first. This was due to sub-aggregators creating deferred collectors before their parent aggregator and then the parent aggregator trying to collect sub aggregators directly instead of going through the deferred wrapper. This commit fixes the issue but we should try to simplify all the pre/post collection logic that we have. Also `breadth_first` is now automatically ignored if the sub aggregators need scores (just like we ignore `execution_mode` when the value does not make sense like using ordinals on a script). Close elastic#9823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Probably introduced in #9544 since I can reproduce the issue on master but not 1.x. The following recreation generates an error:
Deferred collectors cannot be collected directly. They must be collected through the recording wrapper
.The text was updated successfully, but these errors were encountered: