Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Node#stop() in favor of #close() #9841

Closed
s1monw opened this issue Feb 24, 2015 · 1 comment · Fixed by #9921
Closed

Remove Node#stop() in favor of #close() #9841

s1monw opened this issue Feb 24, 2015 · 1 comment · Fixed by #9921
Labels
>breaking v2.0.0-beta1

Comments

@s1monw
Copy link
Contributor

s1monw commented Feb 24, 2015

it's confusing and we don't test the restart functionality. I think we should just remove it entirely.
@s1monw
Copy link
Contributor Author

s1monw commented Feb 24, 2015

btw. this also means we will need to remove TransportNodesRestartAction and friends. IMO that's just fine as we don't rest that either...

@s1monw s1monw mentioned this issue Feb 27, 2015
Merged
s1monw added a commit to s1monw/elasticsearch that referenced this issue Feb 27, 2015
@s1monw
[CORE] Remove Restart API and remove Node#stop()
ce53e20 
The restart API seems pretty esoteric and is entirely untested.
This commit removes it without a replacement.

Closes elastic#9841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>breaking v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Restart API and remove Node#stop() s1monw/elasticsearch
2 participants
@s1monw and others