Schedule pending delete if index store delete fails #9856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bleskes if you have a minute can you look at this? |
| numPending++; | ||
| indicesService.addPendingDelete(test.index(), new ShardId(test.index(), 0), test.getIndexSettings()); | ||
| } | ||
| indicesService.addPendingDelete(test.index(), test.getIndexSettings()); |
There was a problem hiding this comment.
I know it's a pain code wise, but can we sometime put the index delete first in the queue?
There was a problem hiding this comment.
we can sort it for sure
|
LGTM. Left two minor comments. |
|
LGTM, again :) |
s1monw
force-pushed
the
pending_index_delete
branch
2 times, most recently
from
d98ded5
to
6c38840
Compare
We try to lock all shards when an index is deleted but likely not succeeding since shards are still active. To ensure that shards that used to be allocated on that node get cleaned up as well we have to retry or block on the delete until we get the locks. This is not desirable since the delete happens on the cluster state processing thread. Instead of blocking this commit schedules a pending delete for the index just like if we can't delete shards.
s1monw
force-pushed
the
pending_index_delete
branch
from
6c38840
to
306b7b0
Compare
clintongormley
added
:Distributed/Store
clintongormley
changed the title
clintongormley
added
:Distributed/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to lock all shards when an index is deleted but likely not
succeeding since shards are still active. To ensure that shards
that used to be allocated on that node get cleaned up as well we have
to retry or block on the delete until we get the locks. This is not desirable
since the delete happens on the cluster state processing thread. Instead of blocking
this commit schedules a pending delete for the index just like if we can't delete shards.