Add pending tasks count to cluster health #9877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of current pending tasks is useful to detect and overloaded master. This commit adds it to the cluster health API. The complete list can be retrieved from the dedicated pending tasks API. It also adds rest tests for the cluster health variants.
bleskes
added
>enhancement
v2.0.0-beta1
review
v1.5.0
:Core/Infra/REST API
bleskes
changed the title
| @@ -10,8 +10,8 @@ timestamping. | |||
| % curl 192.168.56.10:9200/_cat/health | |||
| 1384308967 18:16:07 foo green 3 3 3 3 0 0 0 | |||
| % curl '192.168.56.10:9200/_cat/health?v&ts=0' | |||
| cluster status nodeTotal nodeData shards pri relo init unassign | |||
| foo green 3 3 3 3 0 0 0 | |||
| cluster status nodeTotal nodeData shards pri relo init unassign tasks | |||
There was a problem hiding this comment.
might be good to name it pending_tasks?
|
left some minor comments - LGTM otherwise |
| numberOfPendingTasks = in.readVInt(); | ||
| } else { | ||
| numberOfPendingTasks = 0; | ||
| } |
There was a problem hiding this comment.
can we make this a regular "readInt" call, and use -1 to denote that we couldn't compute it? otherwise, 0 can be very misleading
bleskes
added a commit
that referenced
this pull request
Feb 25, 2015
The number of current pending tasks is useful to detect and overloaded master. This commit adds it to the cluster health API. The complete list can be retrieved from the dedicated pending tasks API. It also adds rest tests for the cluster health variants. Closes #9877
clintongormley
added
:Data Management/Stats
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of current pending tasks is useful to detect and overloaded master. This commit adds it to the cluster health API. The complete list can be retrieved from the dedicated pending tasks API.
It also adds rest tests for the cluster health variants.