Upgrade to lucene r1662607

[rmuir]

this is not ready: there are test failures!

one category looks like this, even though we havent integrated mockfilesystems, it looks like some tests are using lucenetestcase so they get them anyway. when you see failures with filenames like 'extraNNN' then you know its the new ExtrasFS adding extra files to the directory. if we really need, SuppressFileSystems annotation can be used for these tests, but it would be good to look further:
example:
2> NOTE: reproduce with: ant test -Dtestcase=StoreTest -Dtests.method=testMixedChecksums -Dtests.seed=3E98A98307A8A08F -Dtests.locale=en_GB -Dtests.timezone=America/Kralendijk -Dtests.asserts=true -Dtests.file.encoding=UTF-8
FAILURE 0.02s J1 | StoreTest.testMixedChecksums <<<

Throwable #1: java.lang.AssertionError: extra1 is not in the map: 4 vs. 5

another category of fails is wrong scores for parent/child. The api changes for this upgrade were trivial so I think something might be wrong here. @jpountz any ideas?
example:
2> NOTE: reproduce with: ant test -Dtestcase=ChildrenQueryTests -Dtests.method=testRandom -Dtests.seed=3E98A98307A8A08F -Dtests.locale=es_DO -Dtests.timezone=EET -Dtests.asserts=true -Dtests.file.encoding=UTF-8
FAILURE 0.02s J0 | ChildrenQueryTests.testRandom <<<

Throwable #1: java.lang.AssertionError: actual.getMaxScore() != expected.getMaxScore()
Expected: <1.0F>
got: <5.155753F>

finally percolator looks like it has issues, stuff like this:
FAILURE 0.49s J2 | PercolatorTests.testPercolateSortingWithNoSize <<<

Throwable #1: java.lang.AssertionError:
Expected: <2.0F>
got: <0.0F>

[jpountz]

another category of fails is wrong scores for parent/child. The api changes for this upgrade were trivial so I think something might be wrong here. @jpountz any ideas?

This was an existing bug uncovered by https://issues.apache.org/jira/browse/LUCENE-6262. ParentScoreCollector did not tell the searcher that it needs scores.

[jpountz]

The percolator failures were also due to needsScores. Things should be good now.

[jpountz]

LGTM

[rmuir]

thank you adrien! I can look into the mock filesystem issues.

[rmuir]

I ran tests again after my commit, now there is only one failure:

1> REPRODUCE WITH : mvn clean test -Dtests.seed=28DC6D0EB0CE35C0 -Dtests.class=org.elasticsearch.search.innerhits.InnerHitsTests -Dtests.method="testParentChildMultipleLayers" -Des.logger.level=INFO -Dtests.heap.size=512m -Dtests.locale=mt -Dtests.timezone=Africa/Libreville -Dtests.processors=8
1> Throwable:
1> java.lang.AssertionError: Unexpected ShardFailures: [shard [[5mJs1MmtSkaRjQwrUhJY5g][articles][1]], reason [RemoteTransportException[[node_s4][local[577]][indices:data/read/search[phase/dfs]]]; nested: DfsPhaseExecutionException[[articles][1]: query[child_filtercomment/article],from[0],size[10]: Dfs Failed [Exception du
ring dfs phase]]; nested: NullPointerException; ]]
1> Expected: <0>
1> but: was <1>

[rmuir]

Now tests are passing.

[mikemccand]

LGTM