Tests: Add back tests.cluster #9916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for looking into this @rjernst ! Just one comment: I wonder if it makes sense to have an external cluster with scope TEST. given that the system property value will be the same and we don't recreate anything per test... it looks like it is going to be the same as SUITE, no? Maybe we should only do this for SUITE scope? maybe even barf if we try to run something with scope TEST against the external cluster? Thoughts? |
| @@ -1621,8 +1621,32 @@ protected Settings nodeSettings(int nodeOrdinal) { | |||
| protected Settings transportClientSettings() { | |||
| return ImmutableSettings.EMPTY; | |||
| } | |||
|
|
|||
| private ExternalTestCluster buildExternalCluster(String clusterAddresses) { | |||
| logger.info("BUILDING EXTERNAL CLUSTER"); | |||
|
@javanna I pushed a new commit that addresses your comments. The log message was unintentional. |
|
LGTM thanks @rjernst |
rjernst
added
>test
rjernst
force-pushed
the
fix/external-cluster
branch
from
50c3774
to
6ab717f
Compare
rjernst
force-pushed
the
fix/external-cluster
branch
from
6ab717f
to
1a78074
Compare
This setting is used by the release script to run rest tests against the version being released. It used to work only for tests using the global cluster. Now it supercedes both SUITE and TEST scope test clusters. closes elastic#9916
rjernst
force-pushed
the
fix/external-cluster
branch
from
1a78074
to
d59f5a3
Compare
rjernst
added a commit
that referenced
this pull request
Feb 27, 2015
This setting is used by the release script to run rest tests against the version being released. It used to work only for tests using the global cluster. Now it supercedes both SUITE and TEST scope test clusters. closes #9916
rjernst
added a commit
that referenced
this pull request
Feb 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting is used by the release script to run rest tests against
the version being released. It used to work only for tests using
the global cluster. Now it supercedes both SUITE and TEST scope
test clusters.