Node receiving a cluster state with a wrong master node should reject and throw an error #9963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>bug
v2.0.0-beta1
v1.5.0
:Distributed/Discovery-Plugins
| @@ -766,7 +761,10 @@ public ClusterState execute(ClusterState currentState) { | |||
| if (updatedState == null) { | |||
| updatedState = currentState; | |||
| } | |||
| if (shouldIgnoreNewClusterState(logger, currentState, updatedState)) { | |||
| if (checkWrongMaster(logger, currentState, updatedState)) { | |||
| throw new ElasticsearchIllegalStateException("not following master " + updatedState.nodes().masterNode() + " but following master " + currentState.nodes().masterNode()); | |||
There was a problem hiding this comment.
can we use a similar message to the log bellow: "cluster state from a different master then the current one, rejecting (received {}, current {})
|
Left some small comments |
|
@bleskes I've updated the PR. |
|
LGTM. Thx @martijnvg |
martijnvg
force-pushed
the
zen/reject_cs_with_wrong_master
branch
2 times, most recently
from
e27e5c5
to
6ef67f3
Compare
…eject and throw an error. Previously it was ignored and the publish cluster state timeout would kick in. In that case a stale master node would just wait for the inevitable and waste valuable time. This issue was discovered by the DiscoveryWithServiceDisruptionsTests#testStaleMasterNotHijackingMajority test. Also only perform cluster state versions and wrong master node check inside cluster state update task.
martijnvg
force-pushed
the
zen/reject_cs_with_wrong_master
branch
from
6ef67f3
to
0c254e9
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was ignored and the publish cluster state timeout would kick in. In that case a stale master node would just wait for the inevitable and waste valuable time.
This issue was discovered by the DiscoveryWithServiceDisruptionsTests#testStaleMasterNotHijackingMajority test.
Note this issue doesn't occur in any released version. (just on 1.x and master branches)