Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n][system upgrade] Move i18n.load into core #181589

Open
Bamieh opened this issue Apr 24, 2024 · 1 comment
Open

[i18n][system upgrade] Move i18n.load into core #181589

Bamieh opened this issue Apr 24, 2024 · 1 comment
Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Bamieh
Copy link
Member

Bamieh commented Apr 24, 2024

Move i18n.load into core. This way we can use kfetch and just call i18n.init for both the browser and the server after the files are required differently on each side.

We can also check if we'd need to throw an error if the file fails to load and how to handle it on the browser side if that happens inside core. We can at least log an error.
@Bamieh Bamieh added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n labels Apr 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@Bamieh Bamieh mentioned this issue Apr 24, 2024
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bamieh @elasticmachine