Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Handle text based (ES|QL) query checks consistently in Discover #181639

Open
davismcphee opened this issue Apr 24, 2024 · 1 comment
Open

[Discover] Handle text based (ES|QL) query checks consistently in Discover #181639

davismcphee opened this issue Apr 24, 2024 · 1 comment
Labels
chore Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
Discover

Comments

@davismcphee
Copy link
Contributor

Currently in Discover we use a few different methods of checking if a query is text based (ES|QL):

  • getRawRecordType(query) === RecordRawType.PLAIN
  • isTextBasedQuery(query)
  • isOfAggregateQueryType(query)
  • ...

We also use different variable names for the result which is confusing:

  • isTextBased
  • isPlainRecord
  • ...

We should align on a single method of checking for text based / ES|QL queries and use consistent naming. Possibly something including ES|QL for clarity, along these lines: const isEsqlQuery = isEsqlQueryType(query).
@davismcphee davismcphee added chore Feature:Discover Discover Application loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Apr 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibanamachine kibanamachine added this to Inbox in Discover Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
No open projects
Discover
Inbox
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elasticmachine @davismcphee