New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use actual index for validation instead of .kibana #2555
Comments
Had request for this functionality from Masai Technology. |
Is anyone working on this? Thanks! |
It should be noted that the validator on the dashboard will need to validate against all of the indices that the filter will be included in. Unfortunately, we will need to validate each index pattern separately to ensure that queries run against the index patterns in isolation will not fail (for whatever reason) and the error messages will need to identify the index pattern they fail against. |
There's an additional problem here. The query validator requires the index name be passed in the URL. This is fine for non-timestamp indices, but for timestamped indices we're going to end up with a really huge list of indices which is going to exceed the elasticsearch URL length limit We COULD just get the first index in the list and only validate against that, but its a poor solution. If we are validating a complex query such as a geo or parent/child, and one of the indices in the list is missing the field, the query is going to fail and we're not going to know why. On top of all that, the validator is a hack to make sure we don't fail all shards just because of a typo. We shouldn't even need it. The real solution here is to not even use the query validator, and fix the error messages in elasticsearch so we know why a request failed: elastic/elasticsearch#3303 |
Why not just pass the index wildcard directly as the index name for now? There even seems to be some code for this in components/validate_query/validate_query.js, but no plumbing for This issue (along with #1084 and the lack of arbitrary custom aggregation JSON) severely limit the applications of Kibana by making it impossible, as far as I can tell, to visualize relationships in any manner without denormalizing every field on the dashboard. |
ANy progress on supporting has_parent and has_child filters in the recent Kibana versions? |
As a result of not checking the actual index, the geo distance filter (and perhaps others) don't currently work, if you paste the Query DSL into the Kibana search bar:
Here is the full DSL from Sense which works directly against Elasticsearch 1.6 ("geo.coordinates" field has type "geo_point").
|
I'm seeing the same problem with geohash_cell. |
Closing this as we've removed query validation now that elasticsearch 2.0 has structured errors. |
Following the basic parent/child setup here. ES 1.4.2 & K 4-beta3
All queries work as expected against Elasticsearch
The text was updated successfully, but these errors were encountered: