Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try oxlint #183541

Closed
wants to merge 3 commits into from
Closed

Try oxlint #183541

wants to merge 3 commits into from

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented May 15, 2024

Summary

Try the oxlint tool together with eslint

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611
Copy link
Contributor Author

dej611 commented May 15, 2024

/ci

@dej611
Copy link
Contributor Author

dej611 commented May 16, 2024

/ci

@dej611
Copy link
Contributor Author

dej611 commented May 16, 2024

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 16, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #88 / Agent policies fleet_agent_policies POST /api/fleet/agent_policies/_bulk_get should populate package_policies if called with ?full=true
  • [job] [logs] FTR Configs #88 / Agent policies fleet_agent_policies POST /api/fleet/agent_policies/_bulk_get should populate package_policies if called with ?full=true

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
osquery 114 67 -47

Total ESLint disabled count

id before after diff
osquery 114 67 -47

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants