Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Single Metric Viewer embeddable: ensures creating job rule from anomaly click actions is successful #183554

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented May 15, 2024

Summary

Fixes #183451

This PR updates the utils functions used by the rule editor flyout to create/update/delete job rules. The functions now accept the services they require in the case that they are not available.

This takes a step in the direction of removing dependency on the dependency cache. This needs to be backported to 8.14 so trying to keep code churn as small as possible. A next step will be to convert this utils file to ts and wrap it up as a factory service as we've done with other services that had dependency cache dependencies.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, was able to reproduce the issue on main and the fix in this PR.

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
You should save backporting this till 8.14.1..

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.2MB 4.2MB +255.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit 12035a0 into elastic:main May 17, 2024
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 17, 2024
@alvarezmelissa87 alvarezmelissa87 deleted the ml-smv-click-action-fix branch May 17, 2024 19:11
@szabosteve szabosteve changed the title [ML] Single Metric Viewer embeddable: ensure creating job rule from anomaly click actions is successful [ML] Single Metric Viewer embeddable: ensures creating job rule from anomaly click actions is successful Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Single Metric Viewer embeddable: error when creating job rule from anomaly click actions
6 participants