-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Single Metric Viewer embeddable: ensures creating job rule from anomaly click actions is successful #183554
[ML] Single Metric Viewer embeddable: ensures creating job rule from anomaly click actions is successful #183554
Conversation
…ing rules from any page
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, was able to reproduce the issue on main
and the fix in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
You should save backporting this till 8.14.1.
.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Fixes #183451
This PR updates the utils functions used by the rule editor flyout to create/update/delete job rules. The functions now accept the services they require in the case that they are not available.
This takes a step in the direction of removing dependency on the dependency cache. This needs to be backported to 8.14 so trying to keep code churn as small as possible. A next step will be to convert this utils file to ts and wrap it up as a factory service as we've done with other services that had dependency cache dependencies.