Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] [Security Assistant] Show license upgrade CTA within new flyout (#183576) #183583

Merged
merged 2 commits into from
May 16, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

…tic#183576)

## Summary

This is a fix for showing the license upgrade CTA when using the new
flyout experience with the Security Assistant.

To test, downgrade your license from `trial` to `basic` in Stack
Management and view that the CTA is now back.

The `New Chat` and `Expand Conversations` button are now also disabled
if `!isAssistantAvailable`.

> [!NOTE]
> No logic around determining if the assistant should be shown has
changed, so all existing tests around `assistantAvailability` are still
in place and relevant. This was a surgical fix, and we short-circuit to
show this UI if `!isAssistantAvailable`.

This is a functional change to ESS only, as Serverless completely hides
the assistant when unavailable (`essentials` productTier) as originally
implemented in elastic#164763.

Before / After:
<p align="center">
<img width="300"
src="https://github.com/elastic/kibana/assets/2946766/92b512b6-9cec-4f83-948a-d1e101bdc9ec"
/> <img width="295"
src="https://github.com/elastic/kibana/assets/2946766/c3e39812-27e6-4c4f-ba4c-efb70adff6b5"
/>
</p>

(cherry picked from commit dff2d29)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.2MB 15.2MB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spong

@kibanamachine kibanamachine merged commit 4294bce into elastic:8.14 May 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants