-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security AI Assistant] Fixed assistant availability check in the overlay #183585
[Security AI Assistant] Fixed assistant availability check in the overlay #183585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
desk tested and code LGTM for the Threat Hunting Investigations team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and it works as expected. thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out, tested locally, and code reviewed -- LGTM! Thanks for the speedy fix here @YulNaumenko! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule Management Area LGTM
@@ -105,6 +105,7 @@ export const RulesTableToolbar = React.memo(() => { | |||
getPromptContext={getPromptContext} | |||
suggestedUserPrompt={i18nAssistant.EXPLAIN_THEN_SUMMARIZE_RULE_DETAILS} | |||
tooltip={i18nAssistant.RULE_MANAGEMENT_CONTEXT_TOOLTIP} | |||
isAssistantEnabled={isAssistantEnabled} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call const { hasAssistantPrivilege, isAssistantEnabled } = useAssistantAvailability();
inside the NewChat
component? Why our code needs to be changed every time some internal logic of the Assistant changes?
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…rlay (elastic#183585) This PR adding the check for the assistant license. The initial bug before fix: https://github.com/elastic/kibana/assets/55110838/1afcb112-714a-43e1-8f0d-58fb5b37fc4a after: no error dialog pop up (cherry picked from commit e24502d)
…the overlay (#183585) (#183784) # Backport This will backport the following commits from `main` to `8.14`: - [[Security AI Assistant] Fixed assistant availability check in the overlay (#183585)](#183585) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yuliia Naumenko","email":"jo.naumenko@gmail.com"},"sourceCommit":{"committedDate":"2024-05-17T18:00:46Z","message":"[Security AI Assistant] Fixed assistant availability check in the overlay (#183585)\n\nThis PR adding the check for the assistant license.\r\n\r\nThe initial bug before fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/55110838/1afcb112-714a-43e1-8f0d-58fb5b37fc4a\r\n\r\nafter:\r\nno error dialog pop up","sha":"e24502d70ab98e738552ec46e69707d83152cf44","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:skip","v8.15.0"],"number":183585,"url":"https://github.com/elastic/kibana/pull/183585","mergeCommit":{"message":"[Security AI Assistant] Fixed assistant availability check in the overlay (#183585)\n\nThis PR adding the check for the assistant license.\r\n\r\nThe initial bug before fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/55110838/1afcb112-714a-43e1-8f0d-58fb5b37fc4a\r\n\r\nafter:\r\nno error dialog pop up","sha":"e24502d70ab98e738552ec46e69707d83152cf44"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183585","number":183585,"mergeCommit":{"message":"[Security AI Assistant] Fixed assistant availability check in the overlay (#183585)\n\nThis PR adding the check for the assistant license.\r\n\r\nThe initial bug before fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/55110838/1afcb112-714a-43e1-8f0d-58fb5b37fc4a\r\n\r\nafter:\r\nno error dialog pop up","sha":"e24502d70ab98e738552ec46e69707d83152cf44"}}]}] BACKPORT--> Co-authored-by: Yuliia Naumenko <jo.naumenko@gmail.com>
This PR adding the check for the assistant license.
The initial bug before fix:
errrrec.mov
after:
no error dialog pop up