[TEST] Regex to detect "stashed" values is not useful, throws false-p…

…ositives
elastic · Sep 16, 2016 · 7ff9b20 · 7ff9b20
1 parent a9ee47d
commit 7ff9b20
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/tests/Elasticsearch/Tests/YamlRunnerTest.php b/tests/Elasticsearch/Tests/YamlRunnerTest.php
@@ -651,12 +651,10 @@ private function replaceWithContext($data, $context)
             return $data;
         }
 
-        if (is_string($data) && preg_match('/\$.+?$/', $data)) {
-            if (!array_key_exists($data, $context)) {
-                static::fail(sprintf('Cannot find variable %s in context', $data));
+        if (is_string($data)) {
+            if (array_key_exists($data, $context)) {
+                return $context[$data];
             }
-
-            return $context[$data];
         }
 
         if (!is_array($data) && !$data instanceof \stdClass) {