Skip to content

Commit 9606f52

Browse files
curry684polyfractal
authored andcommitted
[DOCS] Remove incorrect Composer instructions from README (#565)
Instructions on using the --no-dev flag were wrong as Composer will in this case never install the dev dependencies anyway. Dev dependencies are only ever resolved in the root package of an application for exactly the reasons that were described here. A consumer of the library will therefore never get the dev requirements of any library, with any flag.
1 parent dc57bbc commit 9606f52

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ The recommended method to install _Elasticsearch-PHP_ is through [Composer](http
6262
3. Install your dependencies:
6363

6464
```bash
65-
php composer.phar install --no-dev
65+
php composer.phar install
6666
```
6767

6868
4. Require Composer's autoloader
@@ -80,8 +80,6 @@ The recommended method to install _Elasticsearch-PHP_ is through [Composer](http
8080
```
8181
You can find out more on how to install Composer, configure autoloading, and other best-practices for defining dependencies at [getcomposer.org](http://getcomposer.org).
8282

83-
You'll notice that the installation command specified `--no-dev`. This prevents Composer from installing the various testing and development dependencies. For average users, there is no need to install the test suite (which also includes the complete source code of Elasticsearch). If you wish to contribute to development, just omit the `--no-dev` flag to be able to run tests.
84-
8583
PHP Version Requirement
8684
----
8785
Version 5.0 of this library requires at least PHP version 5.6.6 to function. In addition, it requires the native JSON

0 commit comments

Comments
 (0)