Handle null type better

polyfractal · polyfractal · commit 9900cfd0f125 · 2017-04-04T15:30:36.000-04:00
Closes #559
diff --git a/src/Elasticsearch/Client.php b/src/Elasticsearch/Client.php
@@ -1457,7 +1457,7 @@ public function extractArgument(&$params, $arg)
             $params = (array) $params;
         }
 
-        if (isset($params[$arg]) === true) {
+        if (array_key_exists($arg, $params) === true) {
             $val = $params[$arg];
             unset($params[$arg]);
 
diff --git a/src/Elasticsearch/Namespaces/AbstractNamespace.php b/src/Elasticsearch/Namespaces/AbstractNamespace.php
@@ -46,7 +46,7 @@ public function extractArgument(&$params, $arg)
             $params = (array) $params;
         }
 
-        if (isset($params[$arg]) === true) {
+        if (array_key_exists($arg, $params) === true) {
             $val = $params[$arg];
             unset($params[$arg]);
 

Original file line number	Diff line number	Diff line change
`@@ -1457,7 +1457,7 @@ public function extractArgument(&$params, $arg)`
`1457`	`1457`	`$params = (array) $params;`
`1458`	`1458`	`}`
`1459`	`1459`
`1460`		`- if (isset($params[$arg]) === true) {`
	`1460`	`+ if (array_key_exists($arg, $params) === true) {`
`1461`	`1461`	`$val = $params[$arg];`
`1462`	`1462`	`unset($params[$arg]);`
`1463`	`1463`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public function extractArgument(&$params, $arg)`
`46`	`46`	`$params = (array) $params;`
`47`	`47`	`}`
`48`	`48`
`49`		`- if (isset($params[$arg]) === true) {`
	`49`	`+ if (array_key_exists($arg, $params) === true) {`
`50`	`50`	`$val = $params[$arg];`
`51`	`51`	`unset($params[$arg]);`
`52`	`52`