Skip to content

Commit

Permalink
Tests cleaned up a little
Browse files Browse the repository at this point in the history
Removed the empty `foreach()` loops and replaced assertEquals on the array index with an `assertCount()`
  • Loading branch information
carlcasbolt committed Aug 3, 2016
1 parent a79a772 commit afc9af0
Showing 1 changed file with 2 additions and 8 deletions.
Expand Up @@ -78,10 +78,7 @@ public function testWithNoResults()

$responses = new SearchResponseIterator($mock_client, $search_params);

foreach ($responses as $i => $response) {
}

$this->assertEquals(0, $i);
$this->assertCount(0, $responses);
}

public function testWithScan()
Expand Down Expand Up @@ -179,9 +176,6 @@ public function testWithScan()

$responses = new SearchResponseIterator($mock_client, $search_params);

foreach ($responses as $i => $response) {
}

$this->assertEquals(2, $i);
$this->assertCount(2, $responses);
}
}

0 comments on commit afc9af0

Please sign in to comment.