Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating mapping with ignore_conflicts parameter timeouts #3381

Closed
karmi opened this issue Jul 24, 2013 · 1 comment
Closed

Updating mapping with ignore_conflicts parameter timeouts #3381

karmi opened this issue Jul 24, 2013 · 1 comment
Assignees
@javanna
Labels
>regression v0.90.0.Beta1 v0.90.3

Comments

@karmi
Copy link
Contributor

karmi commented Jul 24, 2013

When running the following code against Elasticsearch built from 0.90 branch at b2d0802, the response never finishes:

curl -X DELETE http://localhost:9200/mapped-index

curl -X POST http://localhost:9200/mapped-index -d '{}'

curl -X PUT "http://localhost:9200/mapped-index/article/_mapping" -d '{"article":{"properties":{"body":{"type":"string"}}}}'

curl -X PUT "http://localhost:9200/mapped-index/article/_mapping" -d '{"article":{"properties":{"body":{"type":"integer"}}}}'

# => Conflict (OK)

curl -X PUT "http://localhost:9200/mapped-index/article/_mapping?ignore_conflicts=true" -d '{"article":{"properties":{"body":{"type":"integer"}}}}'

# => Timeout (FAIL)
@ghost ghost assigned javanna Jul 25, 2013
javanna added a commit that referenced this issue Jul 25, 2013
@javanna
Fixed hang when submitting mappings and no changes are made
f66850e 
Added missing listener call before return

Closes #3381
@javanna
Copy link
Member

javanna commented Jul 25, 2013

Side note: the bug was introduced with this recent commit, thus it hadn't been released yet. Good catch @karmi !

javanna added a commit to javanna/elasticsearch that referenced this issue Jul 25, 2013
@javanna
Added regression tests for elastic#3381
cb32841
javanna added a commit to javanna/elasticsearch that referenced this issue Jul 25, 2013
@javanna
Added regression tests for elastic#3381
3fd7576
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@javanna
Fixed hang when submitting mappings and no changes are made
bd7d5b0 
Added missing listener call before return

Closes elastic#3381
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@javanna
Added regression tests for elastic#3381
66634d2
talevy pushed a commit to talevy/elasticsearch that referenced this issue Apr 25, 2018
@colings86
Refactors lifecycle type to its own class (elastic#3381)
3627fed 
To clean up the parsing of the LifecyclePolicy this change moves the LifecycleType to its own class so it can be created in the normal parsing of LifecyclePolicy rather than having to parse to an intermediary object first. The LifecycleType is an interface which can be implemented for different lifecycle types. These types shiould be singletons and are register with the NamedXContentRegistry and NamedWriteableRegistry only so they are available when reading from a stream or parsing.
talevy pushed a commit to talevy/elasticsearch that referenced this issue May 14, 2018
@colings86 @talevy
Refactors lifecycle type to its own class (elastic#3381)
5671d5d 
To clean up the parsing of the LifecyclePolicy this change moves the LifecycleType to its own class so it can be created in the normal parsing of LifecyclePolicy rather than having to parse to an intermediary object first. The LifecycleType is an interface which can be implemented for different lifecycle types. These types shiould be singletons and are register with the NamedXContentRegistry and NamedWriteableRegistry only so they are available when reading from a stream or parsing.
jasontedor pushed a commit that referenced this issue Aug 17, 2018
@colings86 @jasontedor
Refactors lifecycle type to its own class (#3381)
21868f3 
To clean up the parsing of the LifecyclePolicy this change moves the LifecycleType to its own class so it can be created in the normal parsing of LifecyclePolicy rather than having to parse to an intermediary object first. The LifecycleType is an interface which can be implemented for different lifecycle types. These types shiould be singletons and are register with the NamedXContentRegistry and NamedWriteableRegistry only so they are available when reading from a stream or parsing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javanna javanna

Labels
>regression v0.90.0.Beta1 v0.90.3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karmi @javanna