Use the new command line syntax in the init script

[jlecour]

Hi,

I've noticed that in the init script provided by the 1.0.0.RC2 Debian package, the daemon is started with pre-1.0 arguments :

DAEMON_OPTS="-d -p $PID_FILE -Des.default.config=$CONF_FILE -Des.default.path.home=$ES_HOME -Des.default.path.logs=$LOG_DIR -Des.default.path.data=$DATA_DIR -Des.default.path.work=$WORK_DIR -Des.default.path.conf=$CONF_DIR"

According to the documentation we could use a simpler/shorter invocation :

DAEMON_OPTS="-d -p $PID_FILE --default.config=$CONF_FILE --default.path.home=$ES_HOME --default.path.logs=$LOG_DIR --default.path.data=$DATA_DIR --default.path.work=$WORK_DIR --default.path.conf=$CONF_DIR"

It's definitely not a blocker, but it would be nice to be consistent.

[spinscale]

the new arguments are simply an addition and to make it easier for command-line users, but we will not remove the old style.

unsure if it makes sense to switch to the new ones or to not confuse people, when they upgrade from 0.90 here. What do you think?

[jlecour]

If the core team has decided that a the new syntax is better than the old one (and I agree), why would you impose the old one to everybody?

Plus, the old syntax is pre-1.0, so people using this should be aware that anything from a pre-1.0 version is subject to change anytime. And, if someone upgrade but keep her old init script, it would still work.

In a more general point of view, I'm for adopting the best-practices, canonical syntax, … in a project whenever it's introduced. It's a signal that this is the preferred way and people cargo-culting those things at least use the correct form.

[clintongormley]

@jlecour Sorry it has taken a while to look at this.

I agree with you. Please could I ask you sign the CLA so that we can get this in?
http://www.elasticsearch.org/contributor-agreement/

thanks

[jlecour]

📝 ✅