Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Groovy as the default scripting language #6571

Merged
merged 1 commit into from Jun 25, 2014
Merged

Switch to Groovy as the default scripting language #6571

merged 1 commit into from Jun 25, 2014

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jun 20, 2014

Considered a followup to #6233.

@dakrone
Copy link
Member Author

dakrone commented Jun 23, 2014

Fixed the typos, thanks @pickypg

@dakrone
Copy link
Member Author

dakrone commented Jun 23, 2014

The table of plugins is better suited for http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/modules-plugins.html#scripting I think, rather than adding a table into this section of the documentation.

@areek areek assigned rmuir and unassigned rmuir Jun 23, 2014
pickypg
pickypg reviewed Jun 23, 2014
View reviewed changes
docs/reference/modules/scripting.asciidoc
Comma-separated list of methods that are never allowed to be invoked,
regardless of target object.

`script.groovy.sandbox.enabled`::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably one of the most important sandbox options, so consider moving this to the top of the group. I'd also consider making this listing a table with name, description and default value(s).

@pickypg
Copy link
Member

pickypg commented Jun 23, 2014

Ugh, did I comment on the commits rather than the diffs? Sorry about that. LGTM though.

@s1monw
Copy link
Contributor

s1monw commented Jun 24, 2014

IMO we should to this for 1.4 that way folks can upgrade to 1.3 switch to groovy and then move the 1.4 without pain. We can move it into master now already IMO..

other than that LGTM

@s1monw s1monw removed the review label Jun 24, 2014
@dakrone
Copy link
Member Author

dakrone commented Jun 25, 2014

@s1monw sounds good, I will merge to master now and backport to 1.4 once we've created a branch for it.

@dakrone dakrone removed the v1.3.0 label Jun 25, 2014
@dakrone
Switch to Groovy as the default scripting language
5c6d282 
This is a breaking change to move from MVEL -> Groovy
@kimchy
Copy link
Member

kimchy commented Jun 25, 2014

is the removal of mvel, and recommending using the mvel plugin for backward comp. (and setting the default lang for mvel), going to be in a different change?

@dakrone
Copy link
Member Author

dakrone commented Jun 25, 2014

@kimchy yes, I will submit a separate PR for that after this one has been merged.

@dakrone dakrone merged commit 5c6d282 into elastic:master Jun 25, 2014
@jayswan jayswan mentioned this pull request Jul 3, 2014
Closed
@dakrone dakrone added the v1.4.0 label Jul 17, 2014
@clintongormley clintongormley changed the title Switch to Groovy as the default scripting language Scripting: Switch to Groovy as the default scripting language Sep 8, 2014
@dakrone dakrone deleted the feature/groovy-default-scripting-lang branch September 9, 2014 13:47
@mikemccand mikemccand mentioned this pull request Nov 20, 2014
Closed
@clintongormley clintongormley added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Jun 6, 2015
@clintongormley clintongormley changed the title Scripting: Switch to Groovy as the default scripting language Switch to Groovy as the default scripting language Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>breaking :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dakrone @pickypg @s1monw @kimchy @clintongormley @rmuir