Add a blocking variant of close() method to BulkProcessor #6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocks until all bulk requests have completed. This fixes elastic#4158
|
@matt-preston I wonder if you can sign the CLA so I can pull this in? |
|
@matt-preston nevermind I overlooked your CLA - it's on file... |
|
I merged it in - thanks... |
clintongormley
changed the title
|
I'm curious why the new awaitClose() method doesn't take a org.elasticsearch.common.unit.TimeValue as this is used elsewhere in the ElasticSearch API where timeouts are specified? |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocks until all bulk requests have completed.
Updated based on feedback
Updated formatting
Closes #4158
Closes #6314