Add local node to cluster state #6811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, the tribe node needs the local node so it adds it when it starts, but other APIs would benefit from adding the local node, also, adding the local node should be done in a cleaner manner, where it belongs, which is right after the discovery service starts in the cluster service closes elastic#6811
| @@ -37,11 +38,28 @@ | |||
| */ | |||
| public class DiscoveryService extends AbstractLifecycleComponent<DiscoveryService> { | |||
|
|
|||
| private final TimeValue initialStateTimeout; | |||
| private static class InitialState implements InitialStateDiscoveryListener { | |||
There was a problem hiding this comment.
how about calling this class InitialStateListener instead?
|
Left two super minor comments around naming, LGTM otherwise |
kimchy
added a commit
that referenced
this pull request
Jul 10, 2014
Today, the tribe node needs the local node so it adds it when it starts, but other APIs would benefit from adding the local node, also, adding the local node should be done in a cleaner manner, where it belongs, which is right after the discovery service starts in the cluster service closes #6811
|
@javanna cool, renamed and pushed |
clintongormley
changed the title
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Jul 28, 2014
…niff mode This commit effectively reverts e1aa91d , as it is not needed anymore to add the original listed nodes. The cluster state local call made will in fact always return at least the local node (see elastic#6811). There were a couple of downsides caused by putting the original listed nodes among the connected nodes: 1) in the following retries, they weren't seen as listed nodes anymore, thus the light connect wasn't used 2) among the connected nodes some were "bad" duplicates as they are already there and don't contain all needed info for each node. This was causing serialization problems for instance given that the node version was missing on the `DiscoveryNode` object.
javanna
added a commit
that referenced
this pull request
Jul 28, 2014
…niff mode This commit effectively reverts e1aa91d , as it is not needed anymore to add the original listed nodes. The cluster state local call made will in fact always return at least the local node (see #6811). There were a couple of downsides caused by putting the original listed nodes among the connected nodes: 1) in the following retries, they weren't seen as listed nodes anymore, thus the light connect wasn't used 2) among the connected nodes some were "bad" duplicates as they are already there and don't contain all needed info for each node. This was causing serialization problems for instance given that the node version was missing on the `DiscoveryNode` object. Closes #7067
javanna
added a commit
that referenced
this pull request
Jul 28, 2014
…niff mode This commit effectively reverts e1aa91d , as it is not needed anymore to add the original listed nodes. The cluster state local call made will in fact always return at least the local node (see #6811). There were a couple of downsides caused by putting the original listed nodes among the connected nodes: 1) in the following retries, they weren't seen as listed nodes anymore, thus the light connect wasn't used 2) among the connected nodes some were "bad" duplicates as they are already there and don't contain all needed info for each node. This was causing serialization problems for instance given that the node version was missing on the `DiscoveryNode` object. Closes #7067
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the tribe node needs the local node so it adds it when it starts, but other APIs would benefit from adding the local node, also, adding the local node should be done in a cleaner manner, where it belongs, which is right after the discovery service starts in the cluster service