Allow GET access to _all field (return value was always null before) #6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -885,4 +885,30 @@ public void testGetFields_complexField() throws Exception { | |||
| assertThat(getResponse.getField(field).getValues().get(1).toString(), equalTo("value2")); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGet_allField() throws Exception { | |||
| client().admin().indices().prepareCreate("my-index") | |||
There was a problem hiding this comment.
You can use prepareCreate("my-index") instead of client().admin().indices().prepareCreate("my-index")
|
Left small comments. LGTM. |
GET only returned null even when stored if requested with GET like this: `curl -XGET "http://localhost:9200/test/test/1?fields=_all"` Instead, it should simply behave like a String field and return the concatenated fields as String.
brwe
added a commit
that referenced
this pull request
Jul 23, 2014
GET only returned null even when stored if requested with GET like this: `curl -XGET "http://localhost:9200/test/test/1?fields=_all"` Instead, it should simply behave like a String field and return the concatenated fields as String. closes #6924
brwe
changed the title
clintongormley
added
the
:Distributed/CRUD
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET only returned null even when stored if requested with GET like this:
curl -XGET "http://localhost:9200/test/test/1?fields=_all"Instead, it should simply behave like a String field and return the concatenated fields as String.