Fixed filters execution order and fix potential concurrency issue in filter chains #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
changed the title
| @@ -146,12 +148,12 @@ public void run() { | |||
|
|
|||
| private class TransportActionFilterChain implements ActionFilterChain { | |||
|
|
|||
| private volatile int index = 0; | |||
| private AtomicInteger index = new AtomicInteger(); | |||
|
LGTM with 2 minor comments |
…ction filter position Also improved filter chain tests to not rely on execution time, and made filter chain tests look more similar to what happens in reality by removing multiple threads creation in testTooManyContinueProcessing (something we don't support anyway, makes little sense to test it). Closes elastic#7021
…er than the other way around Closes elastic#7019
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix filters ordering which seems to be the opposite to what it should be (#7019). Added missing tests for rest filters.
Solved concurrency issue in both rest filter chain and transport action filter chain (#7021).
Closes #7019
Closes #7021