Test: Allow CliTool to write out stacktraces #7222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,6 +113,14 @@ public void printError(String msg, Object... args) { | |||
| println(Verbosity.SILENT, "ERROR: " + msg, args); | |||
| } | |||
|
|
|||
| public void printError(Throwable t) { | |||
| printError("%s", t.getMessage()); | |||
| boolean isDebugEnabled = "true".equals(System.getProperty(DEBUG_SYSTEM_PROPERTY, System.getenv(DEBUG_ENV_VAR))); | |||
There was a problem hiding this comment.
why not pull this out to a static var called debugMode?
There was a problem hiding this comment.
otherwise, if you want it for testing, it can be done once in the ctor
|
left a few comments, otherwise LGTM |
|
@uboness incorporated all of your review comments, were all good and valid. thx! |
|
LGTM |
In order to have the possibility of debugging on the command line, the user now can either set the es.cli.debug system property which results in stack traces being written to to the terminal. Closes elastic#7222
spinscale
added a commit
that referenced
this pull request
Aug 12, 2014
In order to have the possibility of debugging on the command line, the user now can either set the es.cli.debug system property which results in stack traces being written to to the terminal. Closes #7222
spinscale
added a commit
that referenced
this pull request
Sep 8, 2014
In order to have the possibility of debugging on the command line, the user now can either set the es.cli.debug system property which results in stack traces being written to to the terminal. Closes #7222
clintongormley
added
>test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have the possibility of debugging on the command line, the user
now can either set the ES_CLI_DEBUG environment variable or at es.cli.debug system
property which results in stack traces being written to stdout.